Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-14 19:25:51 +00:00
Code Issues Projects Releases Wiki Activity

Throw a ProtocolException instead of ClassCastException if connecting to a bad peer that does not send a version message on new connections. Resolves issue 81.

Browse Source
This commit is contained in:
Mike Hearn 2011-09-15 16:41:33 +00:00
parent 9009b83af5
commit 6963eb0ca9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/com/google/bitcoin/core/NetworkConnection.java
View File

@ -93,7 +93,12 @@ public class NetworkConnection {
writeMessage(new VersionMessage(params, bestHeight)); writeMessage(new VersionMessage(params, bestHeight));
// When connecting, the remote peer sends us a version message with various bits of // When connecting, the remote peer sends us a version message with various bits of
// useful data in it. We need to know the peer protocol version before we can talk to it. // useful data in it. We need to know the peer protocol version before we can talk to it.
versionMessage = (VersionMessage) readMessage(); Message m = readMessage();
if (!(m instanceof VersionMessage)) {
// Bad peers might not follow the protocol. This has been seen in the wild (issue 81).
throw new ProtocolException("First message received was not a version message but rather " + m);
}
versionMessage = (VersionMessage) m;
// Now it's our turn ... // Now it's our turn ...
// Send an ACK message stating we accept the peers protocol version. // Send an ACK message stating we accept the peers protocol version.
writeMessage(new VersionAck()); writeMessage(new VersionAck());