Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-13 10:45:51 +00:00
Code Issues Projects Releases Wiki Activity

Transaction: print a log warning if lock time is set and a sequence number has not been. This is a common programming error.

Browse Source
This commit is contained in:
Mike Hearn 2015-04-07 15:35:28 +02:00
parent 1e7a13dd27
commit 325e7e170b
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/src/main/java/org/bitcoinj/core/Transaction.java
View File

@ -1058,7 +1058,18 @@ public class Transaction extends ChildMessage implements Serializable {
*/ */
public void setLockTime(long lockTime) { public void setLockTime(long lockTime) {
unCache(); unCache();
// TODO: Consider checking that at least one input has a non-final sequence number. boolean seqNumSet = false;
for (TransactionInput input : inputs) {
if (input.getSequenceNumber() != TransactionInput.NO_SEQUENCE) {
seqNumSet = true;
break;
}
}
if (!seqNumSet || inputs.isEmpty()) {
// At least one input must have a non-default sequence number for lock times to have any effect.
// For instance one of them can be set to zero to make this feature work.
log.warn("You are setting the lock time on a transaction but none of the inputs have non-default sequence numbers. This will not do what you expect!");
}
this.lockTime = lockTime; this.lockTime = lockTime;
} }