Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-13 02:35:52 +00:00
Code Issues Projects Releases Wiki Activity

Note that there is a race in MockNetworkConnection. Fixing it will have to wait until I am less tired.

Browse Source
This commit is contained in:
Mike Hearn 2012-02-13 23:32:14 +01:00
parent e8548a197c
commit 2f72eb64d7
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/com/google/bitcoin/core/MockNetworkConnection.java
View File

@ -65,12 +65,17 @@ public class MockNetworkConnection implements NetworkConnection {
try { try {
// Notify popOutbound() that the network thread is now waiting to receive input. This is needed because // Notify popOutbound() that the network thread is now waiting to receive input. This is needed because
// otherwise it's impossible to tell apart "thread decided to not write any message" from "thread is still // otherwise it's impossible to tell apart "thread decided to not write any message" from "thread is still
// working on it" in a race-free manner. // working on it".
synchronized (this) { synchronized (this) {
waitingToRead = true; waitingToRead = true;
notifyAll(); notifyAll();
} }
Object o = inboundMessageQ.take(); Object o = inboundMessageQ.take();
// BUG 141: There is a race at this point: inbound queue can be empty at the same time as waitingToRead is
// true, which is taken as an indication that all messages have been processed. In fact they have not.
synchronized (this) {
waitingToRead = false;
}
if (o instanceof IOException) { if (o instanceof IOException) {
throw (IOException) o; throw (IOException) o;
} else if (o instanceof ProtocolException) { } else if (o instanceof ProtocolException) {
@ -84,10 +89,6 @@ public class MockNetworkConnection implements NetworkConnection {
} }
} catch (InterruptedException e) { } catch (InterruptedException e) {
throw new IOException(e.getMessage()); throw new IOException(e.getMessage());
} finally {
synchronized (this) {
waitingToRead = false;
}
} }
} }